Additional metrics for HikariCP module #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1976 +/- ##
============================================
- Coverage 70.63% 70.60% -0.04%
+ Complexity 9866 9861 -5
============================================
Files 827 827
Lines 39857 39863 +6
Branches 6068 6069 +1
============================================
- Hits 28154 28144 -10
- Misses 8977 8990 +13
- Partials 2726 2729 +3 ☔ View full report in Codecov by Sentry. |
meiao
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Resolves #1965
Adds additional metrics pulled from the
HikariPoolandHikariConfigclasses. The full list:Database Connection/HikariCP/Busy Count[connections]: Retrieved from HikariPool.getActiveConnections()Database Connection/HikariCP/Idle Count[connections]: Retrieved from HikariPool.getIdleConnections()Database Connection/HikariCP/Total Count[connections]: Retrieved from HikariPool.getTotalConnections()Database Connection/HikariCP/Threads Awaiting Count[connections]: Retrieved from HikariPool.getThreadsAwaitingConnection()Database Connection/HikariCP/Max Pool Size[connections]: Retrieved from HikariConfig.getMaximumPoolSize()Database Connection/HikariCP/Minimum Idle Size[connections]: Retrieved from HikariConfig.getMinimumIdle()Database Connection/HikariCP/Connection Timeout: Retrieved from HikariConfig.getConnectionTimeout()Database Connection/HikariCP/Idle Timeout: Retrieved from HikariConfig.getIdleTimeout()Database Connection/HikariCP/Leak Detection Threshold: Retrieved from HikariConfig.getLeakDetectionThreshold()Database Connection/HikariCP/Maximum Lifetime: Retrieved from HikariConfig.getMaxLifetime()Database Connection/HikariCP/Validation Timeout: Retrieved from HikariConfig.getValidationTimeout()