Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slick 3.5.0 bug fix #2025

Merged
merged 9 commits into from
Aug 23, 2024
Merged

Slick 3.5.0 bug fix #2025

merged 9 commits into from
Aug 23, 2024

Conversation

kanderson250
Copy link
Contributor

@kanderson250 kanderson250 commented Aug 23, 2024

Resolves #1996

Previously, our slick instrumentation wrapped the slick AsyncExecutor in our own NewRelicAsyncExecutor. However, in slick 3.5.0, the concrete implementation AsyncExecutorImpl was introduced, which meant our wrapper ignored AsynExecutorImpl's overridden methods. One consequence of that was incorrect creation of PrioritizedRunnables and disruption of the executor's work queue, causing the application to stall.

We also recognized that wrapping slick's PrioritizedRunnable in a Runnable (only for slick to wrap it back into a PrioritizedRunnable) was less than ideal.

This instrumentation avoids wrapping anything so that we don't have the type issues from before. Instead, we now instrument the prioritizedRunnable method on AsyncExecutor and wrap its generic run Function parameter.

Thanks to @jmreardon-yoppworks for filing the initial bug report and providing a repro to aid our development work.

** Tests **
There are a few new unit tests, plus an AIT branch that has been updated with the new slick module.

@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.58%. Comparing base (9338ecc) to head (a439eb9).
Report is 31 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2025      +/-   ##
============================================
- Coverage     70.60%   70.58%   -0.02%     
- Complexity     9872     9875       +3     
============================================
  Files           829      829              
  Lines         39914    39945      +31     
  Branches       6077     6078       +1     
============================================
+ Hits          28181    28195      +14     
- Misses         9002     9020      +18     
+ Partials       2731     2730       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanderson250 kanderson250 merged commit 3163d99 into main Aug 23, 2024
111 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Instrumentation is bugged for Slick 3.5.0
3 participants