Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1996
Previously, our slick instrumentation wrapped the slick
AsyncExecutor
in our ownNewRelicAsyncExecutor
. However, in slick 3.5.0, the concrete implementationAsyncExecutorImpl
was introduced, which meant our wrapper ignoredAsynExecutorImpl's
overridden methods. One consequence of that was incorrect creation ofPrioritizedRunnables
and disruption of the executor's work queue, causing the application to stall.We also recognized that wrapping slick's
PrioritizedRunnable
in aRunnable
(only for slick to wrap it back into aPrioritizedRunnable
) was less than ideal.This instrumentation avoids wrapping anything so that we don't have the type issues from before. Instead, we now instrument the
prioritizedRunnable
method onAsyncExecutor
and wrap its genericrun
Function parameter.Thanks to @jmreardon-yoppworks for filing the initial bug report and providing a repro to aid our development work.
** Tests **
There are a few new unit tests, plus an AIT branch that has been updated with the new slick module.