-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis async client breaks when instrumented #818
Comments
I just wanted to confirm that this breaks channels if you're using the pubsub channel layer with async consumers. |
@drewbrew I didn't see you message, but most likely it will break it. I'll try to downgrade to 8.5.0 as you mentioned in the other issue |
Thanks, @marcoaaguiar. I can confirm we've been using 8.5.0 in production with no trouble for the past two weeks and change. |
The latest release of the agent should have a fix for this issue. If this is still an issue for you with the latest version (v8.10.0), we can reopen this ticket |
Description
When I run my code with NR auto instrumentation it wraps
redis.asyncio.client.RedisClient.pubsub
with an async wrapper which causes an error when I try to invoke a__aenter__
on the object.Expected Behavior
A regular sync wrapper should have been used to not change the library default behavior.
**Troubleshooting or [NR Diag]
client.subrcibe() =>
<coroutine object _wrap_AioRedis_method_wrapper.<locals>._nr_wrapper_AioRedis_async_method_ at 0x7fefca629e00>
error on `async with pubsub:
Steps to Reproduce
Your Environment
Additional context
Similar issues have been posted before. #623 was closed but there is still other open (#782, #807) - including PR that might solve this issue (#782, #808).
Unfortunately we will have to disable NR while this is not solved leaving an unmonitored application.
The text was updated successfully, but these errors were encountered: