Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aria-label from <div> #1179

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Conversation

JuliaKirschenheuter
Copy link
Contributor

It is not allowed to put aria-label not on the interactive elements.

Besides this such text isn't nice for screen reader like: "MIME type httpd/unix-directory", "MIME type image/png", "MIME type text/markdown". Would be much better to have just "folder", "document", "image". Some kind of mapping can be done in future (it is not mandatory). For now removing wrong attribute: nextcloud/server#42626 (comment)

@JuliaKirschenheuter JuliaKirschenheuter force-pushed the fix/42626-remove_attr_on_wrong_element branch from 43b7723 to f995fbc Compare January 17, 2024 13:17
@emoral435 emoral435 force-pushed the fix/42626-remove_attr_on_wrong_element branch from f995fbc to 4108024 Compare January 17, 2024 16:09
Signed-off-by: julia.kirschenheuter <[email protected]>
@susnux susnux force-pushed the fix/42626-remove_attr_on_wrong_element branch from 4108024 to 7c817c9 Compare January 17, 2024 17:23
@susnux susnux merged commit d34dc98 into main Jan 17, 2024
10 checks passed
@susnux susnux deleted the fix/42626-remove_attr_on_wrong_element branch January 17, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review accessibility for accessibility work or changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants