-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error spam "$attrs is readonly" and "$listeners is readonly" with NcButton #5267
Comments
It doesn't do anything specific, just passing attrs. There is no actual mutation of This happens when parent component instance and child component instance are from different Vue when there are multiple Vue on the page. Vue fails to check that the instance is the parent. |
*Checking some guesses |
A bit more details. When a VNode with a component is rendered for the first time, component instance is created. During instance creation, https:/vuejs/vue/blob/main/src/core/instance/render.ts#L51-L85 Here it checks https:/vuejs/vue/blob/main/src/core/instance/lifecycle.ts#L25
So, this error is shown when in a VDOM tree there are VNodes created by different Vue copies on the page and parent from one Vue updates child from another Vue. |
So... There is nothing we can do on the Because Viewer's components are used directly as a component in Viewer's rendering, Something like https:/ueberdosis/tiptap/blob/main/packages/vue-2/src/VueNodeViewRenderer.ts#L67 The only problem — to get Vue from Viewer in |
Closing, because there is no issue on Fix: nextcloud/text#5402 |
We have introduced a link popover recently in text. The component is loaded via a tiptap mechanism. It's triggering lot of errors in the console:
Removing NcButton from the component makes the errors go away. So I suspect it's due to the
attrs
magic that NcButton applies.See also:
The text was updated successfully, but these errors were encountered: