Adapt test to modern getMount() #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artonge
force-pushed
the
artonge/test/adapt_to_modern_getMount
branch
from
8e595a0
to
c9c7545
Compare
Closed
artonge
force-pushed
the
artonge/test/adapt_to_modern_getMount
branch
from
c9c7545
to
daf31c0
Compare
That sounds like a very breaking change, but nextcloud/server#37039 doesn't mention it. Can you add it yourself or post it in the relevant PR so the author can take care?! |
1 task
|
Posted in the PR for Robin. |
artonge
force-pushed
the
artonge/test/adapt_to_modern_getMount
branch
from
daf31c0
to
f6d1600
Compare
nickvergessen
approved these changes
May 12, 2023
MountManager->getMount() is not throwing an error instead of returning null. This commit makes sure that we handle properly the cases of un-existing mount. Signed-off-by: Louis Chemineau <[email protected]>
artonge
force-pushed
the
artonge/test/adapt_to_modern_getMount
branch
from
f6d1600
to
d6cbf07
Compare
delete-merged-branch
bot
deleted the
artonge/test/adapt_to_modern_getMount
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MountManager->getMount()is now throwing an error instead of returningnull.This commit makes sure that we handle properly the cases of un-existing mount.