Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invisible "Cancel" button #7633

Closed
Valdnet opened this issue Dec 8, 2020 · 1 comment
Closed

Invisible "Cancel" button #7633

Valdnet opened this issue Dec 8, 2020 · 1 comment
Labels
approved bug good first issue help wanted high
Milestone
Nextcloud App 3.15.0

Comments

@Valdnet
Copy link
Contributor

Valdnet commented Dec 8, 2020

Steps to reproduce

  1. Launch the app.
  2. Go to app settings.
  3. Select data locations from general settings.

Expected behaviour

  • Visible Cancel button.

Actual behaviour

  • Invisible Cancel button.

obraz

obraz

Environment data

Android version: 10

Nextcloud app version: 3.14.1 and Dev 20201208

Nextcloud server version: 20.0.2
@Valdnet Valdnet added the bug label Dec 8, 2020
@AndyScherzinger
Copy link
Member

true for all other addition selection dialogs within the settings screen (they make use of the fallback theme)

czlucius added a commit to czlucius/nextcloud-android that referenced this issue Dec 14, 2020
@czlucius
Fix issue nextcloud#7633
75f754e 
Add ThemedListPreference, extending ListPreference, to theme dialog created by ListPreference.
Add style for dialog, setting default button text color in fallback dialog theme to ?android:attr/textColorPrimary
@czlucius czlucius mentioned this issue Dec 14, 2020
Merged
1 task
czlucius added a commit to czlucius/nextcloud-android that referenced this issue Dec 16, 2020
@czlucius
Fix issue nextcloud#7633
dc06c17 
Add button style for `AlertDialog` buttons to default `AlertDialog` style, `owncloud.AlertDialog`.
czlucius added a commit to czlucius/nextcloud-android that referenced this issue Dec 17, 2020
@czlucius
Fix issue nextcloud#7633 by adding button style
36c6729 
Add `android:buttonBarButtonStyle` to `FallbackTheming.Dialog`, modifying the button style of the fallback `AlertDialog`, so that the button would not appear as invisible.
AndyScherzinger added a commit that referenced this issue Dec 17, 2020
@AndyScherzinger
Merge pull request #7664 from czlucius/fix-issue-7633
03606f0 
Fix issue #7633
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.15.0 milestone Dec 17, 2020
tobiasKaminsky added a commit that referenced this issue Dec 23, 2020
@tobiasKaminsky
daily dev 20201223
810615d 
fix not updating sharee list after creating a new link
Downgrade firebase-messaging use NC specific user agent for Push
Remove snapshot repo
If path is not set or empty do not run any media scanner
Change alert dialog button text color
Change button text color from black to system text color
Fix issue #7633 by adding button style
fix crash when changing theme after showing media pane
Update help link
Fix upload by sharing link with defensive check during mtime read
Update translations
Update Nextcloud Android library
Update 3rd-party dependencies
tobiasKaminsky pushed a commit that referenced this issue Jan 25, 2021
@czlucius @tobiasKaminsky
Fix issue #7633 by adding button style
841eeb7 
Add `android:buttonBarButtonStyle` to `FallbackTheming.Dialog`, modifying the button style of the fallback `AlertDialog`, so that the button would not appear as invisible.
@AndyScherzinger AndyScherzinger removed this from the Nextcloud App 3.15.0 milestone Feb 2, 2021
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.15.0 milestone Feb 23, 2021
thelittlefireman pushed a commit to thelittlefireman/android that referenced this issue Mar 19, 2021
@czlucius
Fix issue nextcloud#7633 by adding button style
c7ad2e8 
Add `android:buttonBarButtonStyle` to `FallbackTheming.Dialog`, modifying the button style of the fallback `AlertDialog`, so that the button would not appear as invisible.

Signed-off-by: thelittlefireman <[email protected]>
thelittlefireman pushed a commit to thelittlefireman/android that referenced this issue Mar 19, 2021
@AndyScherzinger
Merge pull request nextcloud#7664 from czlucius/fix-issue-7633
85a786b 
Fix issue nextcloud#7633
Signed-off-by: thelittlefireman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
approved bug good first issue help wanted high
Projects
None yet
Milestone
Nextcloud App 3.15.0
Development

No branches or pull requests
2 participants
@AndyScherzinger @Valdnet