Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AppAPIService): encode query parameter arrays via http_build_query #412

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

edward-ly
Copy link
Contributor

Resolves #384. If the checks still pass and this gets merged, perhaps we should take a look at other apps to see if they need to be updated in the same way.

Copy link
Collaborator

@andrey18106 andrey18106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, better also to double check within the issue to confirm it works as expected now.

Copy link
Member

@bigcat88 bigcat88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's merge this and request backports.

I'll test it heavily this week with Flow and Visionatrix, after that we can approve & merge backports.

@bigcat88 bigcat88 merged commit f15c6ea into main Oct 8, 2024
30 checks passed
@bigcat88 bigcat88 deleted the fix/query-array-params branch October 8, 2024 13:50
@bigcat88
Copy link
Member

/backport to stable29

Copy link

backportbot bot commented Oct 14, 2024

The backport to stable29 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable29
git pull origin stable29

# Create the new backport branch
git checkout -b backport/412/stable29

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 2b307976

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/412/stable29

Error: Failed to cherry pick commits: error: no cherry-pick or revert in progress
fatal: cherry-pick failed


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query param got stripped in request through proxy
3 participants