Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rtl): navigation buttons #6416

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(rtl): navigation buttons #6416

wants to merge 1 commit into from

Conversation

hamza221
Copy link
Contributor

fix #6402

b a
image image

Signed-off-by: Hamza Mahjoubi <[email protected]>
@hamza221 hamza221 added 3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills labels Oct 11, 2024
@hamza221 hamza221 self-assigned this Oct 11, 2024
@hamza221
Copy link
Contributor Author

@DorraJaouad Can you please test this, I'm not sure how it's supposed to work UX wise. I switched the buttons but it feels wrong

Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 29.26%. Comparing base (d039b91) to head (6e1f6ad).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
...NavigationHeader/AppNavigationHeaderDatePicker.vue 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6416      +/-   ##
============================================
+ Coverage     23.54%   29.26%   +5.72%     
- Complexity      454      908     +454     
============================================
  Files           247      288      +41     
  Lines         11701    13948    +2247     
  Branches       2213     2231      +18     
============================================
+ Hits           2755     4082    +1327     
- Misses         8625     9545     +920     
  Partials        321      321              
Flag Coverage Δ
javascript 15.04% <0.00%> (-0.03%) ⬇️
php 59.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamza221
Copy link
Contributor Author

@DorraJaouad are you on latest master (server) ?

@DorraJaouad
Copy link

@DorraJaouad are you on latest master (server) ?

No, master is now updated 🙈

The directions should be the opposite (e.g: left side button leads to next month)

Recording.2024-10-12.165218.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Related to design, interface, interaction design, UX, etc. skill:frontend Issues and PRs that require JavaScript/Vue/styling development skills
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation buttons should be flipped
2 participants