Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix grammar, unnecessary escape in closed circle description #338

Closed
wants to merge 4 commits into from

Conversation

hoxia
Copy link

@hoxia hoxia commented Oct 5, 2019

Change incorrect use of "it's", and remove unnecessary escaped apostrophe by changing "who\'s in it" to "its membership".

Note that this change likely needs bulk edits (find-and-replace) across localization files. Only en_GB was edited to demonstrate the likely needed change.

@hoxia
Copy link
Author

hoxia commented Dec 12, 2019

If the purpose of this change is unclear:

The current, escaped, "who\'s in it" appears with the escape in the UI. To fix this, either the escape should be corrected, or an apostrophe should be avoided. It's possible to word the string more clearly without the apostrophe anyway.

@blizzz blizzz added this to the Nextcloud 25 milestone Apr 21, 2022
@blizzz blizzz modified the milestones: Nextcloud 25, Nextcloud 26 Sep 22, 2022
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 9, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@AndyScherzinger
Copy link
Member

AndyScherzinger commented Aug 1, 2024

Hi @hoxia

Unfortunately I'll have to close the PR. The translations in the l10n folder are fully handled via transifex, so they would need to be fixed at https://app.transifex.com/nextcloud/nextcloud/translate/#en_GB/circles/485650950

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants