Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match X-Robots-Tag recommendation in Nextcloud docs #370

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

jfredrickson
Copy link
Contributor

Pull Request

Description of the change

The latest Nextcloud documentation suggests setting X-Robots-Tag to noindex, nofollow. This changes the nginx configuration to align with that recommendation.

More context: nextcloud/server#37357

Specifically, this explanation: nextcloud/server#37357 (comment)

Benefits

Prior to this change, someone who is following the Nextcloud documentation to set up their instance may set their nginx reverse proxy to add the X-Robots-Tag: noindex, nofollow header. Then their Nextcloud instance still generates the following warning even though they followed the documentation:

The "X-Robots-Tag" HTTP header is not set to "noindex, nofollow". This is a potential security or privacy risk, as it is recommended to adjust this setting accordingly.

This is because the Helm chart's included nginx instance still adds X-Robots-Tag: none.

Possible drawbacks

I'm unsure if older Nextcloud installations will then start to complain that the older recommendation of X-Robots-Tag: none isn't implemented.

Applicable issues

N/A

Additional information

N/A

Checklist

@provokateurin provokateurin self-requested a review April 6, 2023 12:08
@provokateurin provokateurin merged commit 400e791 into nextcloud:master Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants