Fix account creation with the registration app #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there really no interest in having this bug fixed? |
|
Can this please be looked at? I really like to stop having to use my own fork and have this bug fixed in the main version. |
|
All points from the review have been fixed, can this be merged? |
|
Same as with the other PR. Mind a rebase? |
When an account is created from the registration app there is no user session. This lead to an Error in createUser() as $adminUser is used while null, but only Exceptions are cought there. Add a check that throw an Exception when $adminUser is null to fallback in the code path that handle the case where the admin user is not from the LDAP directory. Signed-off-by: Alban Bedel <[email protected]>
|
Rebase done |
blizzz
approved these changes
Nov 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an account is created from the registration app there is no user session. This lead to an Error in createUser() as $adminUser is used while null, but only Exceptions are cought there.
Add a check that throw an Exception when $adminUser is null to fallback in the code path that handle the case where the admin user is not from the LDAP directory.
The documentation should perhaps also mention that using the "admin must be from LDAP" feature is not compatible with the registration app.