ci: Run psalm against lowest php version

Signed-off-by: Julius Knorr <[email protected]>
nextcloud · Oct 11, 2024 · 5bef199 · 5bef199
1 parent 2314eef
commit 5bef199
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/.github/workflows/psalm-matrix.yml b/.github/workflows/psalm-matrix.yml
@@ -39,10 +39,10 @@ jobs:
  - name: Checkout
  uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
 
- - name: Set up php${{ matrix.php-versions }}
+ - name: Set up php${{ matrix.php-min }}
  uses: shivammathur/setup-php@c541c155eee45413f5b09a52248675b1a2575231 # v2.31.1
  with:
- php-version: ${{ matrix.php-versions }}
+ php-version: ${{ matrix.php-min }}
  extensions: bz2, ctype, curl, dom, fileinfo, gd, iconv, intl, json, libxml, mbstring, openssl, pcntl, posix, session, simplexml, xmlreader, xmlwriter, zip, zlib, sqlite, pdo_sqlite
  coverage: none
  ini-file: development

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -41,8 +41,11 @@ jobs:
  tools: phpunit:9
  env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+ - name: Install latest dev Nextcloud PHP API (max only)
+ if: matrix.version == 'max'
+ run: composer require --prefer-dist --dev nextcloud/ocp:dev-master
  - name: Install Dependencies
- run: composer install --no-dev
+ run: composer install --prefer-dist
  - name: Prepare MySQL database
  run: |
  sudo systemctl start mysql

diff --git a/tests/psalm-baseline.xml b/tests/psalm-baseline.xml
@@ -121,6 +121,9 @@
  </MoreSpecificReturnType>
  </file>
  <file src="lib/Migration/EditorHint.php">
+ <DeprecatedMethod>
+ <code><![CDATA[getAppValue]]></code>
+ </DeprecatedMethod>
  <MissingReturnType>
  <code><![CDATA[run]]></code>
  </MissingReturnType>
@@ -189,6 +192,11 @@
  </MissingReturnType>
  </file>
  <file src="lib/Service/SettingsService.php">
+ <DeprecatedMethod>
+ <code><![CDATA[\OCP\Util::getVersion()]]></code>
+ <code><![CDATA[getAppValue]]></code>
+ <code><![CDATA[getAppValue]]></code>
+ </DeprecatedMethod>
  <InvalidOperand>
  <code><![CDATA[$this->defaultSuffixes]]></code>
  </InvalidOperand>