Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract preview and fullscreen actions from three-dot-menu #1249

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Macavity
Copy link

This PR explodes the preview/edit-toggle and the full-screen button from the three-dots menu as suggested in #366.
In the discussion it sounded like it would be an idea to only extract the preview/edit-toggle, but as only the fullscreen was left in the menu, that didn't seem reasonable.

Two screenshots what the result looks like:
Screenshot 2024-03-17 at 19 25 22
Screenshot 2024-03-17 at 19 25 13

Open for any feedback, the discussion in #366 has been stale for while already.

@joshtrichards joshtrichards added design Related to the design or user experience feature: app navigation Related to the app navigation 3. to review labels Aug 8, 2024
@joshtrichards joshtrichards linked an issue Aug 8, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review design Related to the design or user experience feature: app navigation Related to the app navigation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

explode the 3 dots menu
2 participants