Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard javascript file is loaded when no Photos widgets are used #2674

Open
philiprenich opened this issue Oct 3, 2024 · 0 comments
Open
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working

Comments

@philiprenich
Copy link

Describe the bug
Even when there are no widgets on my Dashboard, apps/photos/js/photos-dashboard.js is loaded. It's a large file, and seems to be unnecessary when there are no Photos widgets active, so will have a significant impact on load time - both downloading and parsing that file.

Loading the Photos app shows that photos-main.js is downloaded, so it is a different file as opposed to being pre-emptively downloaded.

To Reproduce
Steps to reproduce the behavior:

  1. Have Photos installed
  2. Open Dev Tools to Network tab, filter by JS or "photos"
  3. Freshly navigate to the dashboard
  4. See the file downloaded in the network tab

Expected behavior
The file should not be loaded when there is no Photos related widget on the dashboard.

Screenshots
Image

Desktop (please complete the following information):

  • OS: MacOS
  • Browser Firefox
  • Version 131
    Additional context
    The file is really big at over 4mb (that's another topic 😅). Even if I had the On This Day widget loaded, it's just showing an image so I'm not sure why it's that large?
@philiprenich philiprenich added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant