Fix issues of GPS metadata handling #2636
Conversation
nmbgeek
force-pushed
the
master
branch
2 times, most recently
from
ebc323d
to
beb911c
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
@nmbgeek can you squash your changes? |
@artonge I'm not sure I did this correctly as now the nextcloud-bot commits are showing here and my repo shows being 22 commits ahead. Trying to rebase them wants me to accept changes to quite a few different files. Do I need to create a new branch and replace my master or is what I have done sufficient? |
|
My bad, I rebased your branch to run the CI against the latest master. This should help you: git reset --hard HEAD~11 # Deletes the 11 latest commits from your branch
git cherry-pick b674472a58b9fb2535374f3cb4e72e6155e9c563 # Apply your change again
git push --force-with-lease # Push to the remote branch |
Signed-off-by: Clint Johnson <[email protected]> GPSAltitudeRef below sea level Fix GPSAltitudeRef below sea level. Signed-off-by: Clint Johnson <[email protected]>
#2541 #2635 #2616 Directly address these issues
#2260 Address some of the issues in the comments
This pull request adds handling null GPS coordinates and also coordinates that are not a string.