shorten oauth2 client names before resizing the column

Signed-off-by: Julien Veyssier <[email protected]>
nextcloud · Jun 7, 2023 · e9c0b0a · e9c0b0a
1 parent e490de3
commit e9c0b0a
Showing 1 changed file with 21 additions and 0 deletions.
diff --git a/lib/private/Repair/Owncloud/MigrateOauthTables.php b/lib/private/Repair/Owncloud/MigrateOauthTables.php
@@ -77,6 +77,27 @@ public function run(IOutput $output) {
  $schema = new SchemaWrapper($this->db);
  $table = $schema->getTable('oauth2_clients');
  if ($table->getColumn('name')->getLength() !== 64) {
+ // shorten existing values before resizing the column
+ $qb = $this->db->getQueryBuilder();
+ $qb->update('oauth2_clients')
+ ->set('name', $qb->createParameter('shortenedName'))
+ ->where($qb->expr()->eq('id', $qb->createParameter('theId')));
+
+ $qbSelect = $this->db->getQueryBuilder();
+ $qbSelect->select('id', 'name')
+ ->from('oauth2_clients');
+
+ $result = $qbSelect->executeQuery();
+ while ($row = $result->fetch()) {
+ $id = $row['id'];
+ $shortenedName = mb_substr($row['name'], 0, 64);
+ $qb->setParameter('theId', $id, IQueryBuilder::PARAM_INT);
+ $qb->setParameter('shortenedName', $shortenedName, IQueryBuilder::PARAM_STR);
+ $qb->executeStatement();
+ }
+ $result->closeCursor();
+
+ // safely set the new column length
  $table->getColumn('name')->setLength(64);
  }
  if ($table->hasColumn('allow_subdomains')) {