Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Restrict users to only share with users in their groups does not work #42501

Closed
5 of 8 tasks
Tracked by #3888
pabloeisenhut opened this issue Dec 27, 2023 · 12 comments · Fixed by #46830
Closed
5 of 8 tasks
Tracked by #3888

[Bug]: Restrict users to only share with users in their groups does not work #42501

pabloeisenhut opened this issue Dec 27, 2023 · 12 comments · Fixed by #46830

Comments

@pabloeisenhut
Copy link

⚠️ This issue respects the following points: ⚠️

Bug description

The function Restrict users to share only with users in their groups no longer works. Regardless of whether the function is activated or not, users cannot see each other outside their groups.

Steps to reproduce

  1. create two users who are each in their own group
  2. check whether the function Restrict users to share only with users in their groups is deactivated
  3. log in to one of the users and open the share dialog of a file

Expected behavior

the user you are logged into should be able to see the other user in the share dialog and share files.

Installation method

Community Docker image

Nextcloud Server version

28

Operating system

None

PHP engine version

None

Web server

None

Database engine version

PostgreSQL

Is this bug present after an update or on a fresh install?

None

Are you using the Nextcloud Server Encryption module?

None

What user-backends are you using?

  • Default user-backend (database)
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Configuration report

No response

List of activated Apps

No response

Nextcloud Signing status

No response

Nextcloud Logs

No response

Additional info

No response

@pabloeisenhut pabloeisenhut added 0. Needs triage Pending check for reproducibility or if it fits our roadmap bug labels Dec 27, 2023
@szaimen
Copy link
Contributor

szaimen commented Jan 3, 2024

cc @Fenn-CS @sorbaugh

@pabloeisenhut
Copy link
Author

In my case it also affects Talk. Users cannot see each other. As described in nextcloud/spreed#8990

@nextcloud nextcloud deleted a comment from sorbaugh Jan 17, 2024
@nextcloud nextcloud deleted a comment from ArtificialOwl Jan 17, 2024
@pabloeisenhut
Copy link
Author

Is there anything I can do to help?

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Jul 28, 2024

Hello @pabloeisenhut I was not able to reproduce this bug on 28, are you still able to see this error! If so yes then you can jump on a call with me and help me reproduce it or simply provide more information here.

@Fenn-CS Fenn-CS added investigation and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jul 28, 2024
@pabloeisenhut
Copy link
Author

Hey @Fenn-CS , the error still exists, I think we can solve it faster with a call.

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Jul 28, 2024

@pabloeisenhut if you are available now you can join me here : https://cloud.nextcloud.com/call/5051630186

Otherwise, please kindly leave me a message in there so we can arrange an appointment.

@pabloeisenhut
Copy link
Author

@Fenn-CS I can be reached today from 4 p.m., is that okay with you?

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Jul 28, 2024

@Fenn-CS I can be reached today from 4 p.m., is that okay with you?

Please can you use the talk link? It would only be up for a limited amount of time.

I mean we can actually text on the link to avoid spamming this ticket.

@pabloeisenhut
Copy link
Author

@Fenn-CS The link requires an account or has expired? Feel free to create an account if that's possible, I wanted to join the public Design Team group anyway.

@Fenn-CS
Copy link
Contributor

Fenn-CS commented Jul 28, 2024

@Fenn-CS The link requires an account or has expired? Feel free to create an account if that's possible, I wanted to join the public Design Team group anyway.

It's open now for you to join as a guest.

@pabloeisenhut
Copy link
Author

Okay, by try and error I have found the mistake. It's because of this setting:

Bildschirmfoto vom 2024-07-28 15-23-27

In my opinion, the setting gives the impression that by activating these options, functions are added and not restricted.

The documentation explains these settings well, but I find the options misleading from the wording in the settings.

I think the wording should definitely be changed. For example to:

  • Only allow username autocompletion to users within the same groups and limit system address books to users in the same groups

  • Only allow username autocompletion to users based on phone number integration

Fenn-CS added a commit that referenced this issue Jul 28, 2024
The existing is incorrect and can be misleading as seen in : #42501

Signed-off-by: fenn-cs <[email protected]>
@Fenn-CS
Copy link
Contributor

Fenn-CS commented Jul 28, 2024

Fair point now proposed correct wording : #46830

Fenn-CS added a commit that referenced this issue Jul 30, 2024
The existing is incorrect and can be misleading as seen in : #42501

Signed-off-by: fenn-cs <[email protected]>
Fenn-CS added a commit that referenced this issue Jul 30, 2024
The existing is incorrect and can be misleading as seen in : #42501

Signed-off-by: fenn-cs <[email protected]>
Fenn-CS added a commit that referenced this issue Jul 30, 2024
The existing is incorrect and can be misleading as seen in : #42501

Signed-off-by: fenn-cs <[email protected]>
@Fenn-CS Fenn-CS closed this as completed Jul 30, 2024
AndyScherzinger pushed a commit that referenced this issue Jul 31, 2024
The existing is incorrect and can be misleading as seen in : #42501

Signed-off-by: fenn-cs <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants