Use sabre function directly rather than duplicating it #31758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
come-nc
force-pushed
the
fix/utf8-detection-fix
branch
from
9c6eab7
to
56eff12
Compare
|
I don’t get it |
Merged
Merged
|
@CarlSchwan Do you know how I can import the function from Sabre? It seems the autoloader can’t find it. |
|
The point is to fix #31212 We can also fix it on our side and hope it will be enough, I do not know if our code goes through the sabre function or not, if we fix on our side it may fix it in UI but not through dav or something. |
Merged
|
strange if it didn't work for you because it did here on this other line: https:/nextcloud/server/blob/master/lib/private/AppFramework/Http/Request.php#L754 |
PVince81
force-pushed
the
fix/utf8-detection-fix
branch
from
bbcc318
to
a2d99eb
Compare
|
I've updated the psalm baseline for the new entry |
|
/rebase |
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Vincent Petry <[email protected]>
come-nc
force-pushed
the
fix/utf8-detection-fix
branch
from
a2d99eb
to
9cfc70d
Compare
CarlSchwan
approved these changes
Apr 26, 2022
|
/backport to 24 |
come-nc
requested review from
a team,
PVince81,
icewind1991 and
blizzz
and removed request for
a team
blizzz
approved these changes
Apr 29, 2022
|
The backport to 24 failed. Please do this backport manually. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Côme Chilliet [email protected]