Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate small preview straight away if Imaginary is enabled #31864

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Apr 6, 2022

If Imaginary is enabled, let's generate the small preview straight away, instead of requesting specific sizes to trigger this.
We have nothing to lose in terms of performances

Followup:

@skjnldsv skjnldsv added this to the Nextcloud 24 milestone Apr 6, 2022
@skjnldsv skjnldsv requested review from PVince81, CarlSchwan and a team April 6, 2022 16:55
@skjnldsv skjnldsv self-assigned this Apr 6, 2022
@skjnldsv skjnldsv requested review from come-nc and removed request for a team April 6, 2022 16:55
@blizzz blizzz mentioned this pull request Apr 7, 2022
@skjnldsv skjnldsv merged commit 0e29dc8 into master Apr 7, 2022
@skjnldsv skjnldsv deleted the fix/preview-generate-imaginary-request branch April 7, 2022 09:50
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: previews and thumbnails technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants