Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: use the viewer to render single file shares #33347

Merged
merged 3 commits into from
Aug 26, 2022

Conversation

max-nextcloud
Copy link
Contributor

Still some issues with positioning and sizing of the image and video.

@max-nextcloud max-nextcloud force-pushed the feature/use-viewer-for-singe-file-shares branch 2 times, most recently from f292125 to 38503ed Compare July 26, 2022 16:09
@max-nextcloud max-nextcloud marked this pull request as ready for review July 26, 2022 16:09
@max-nextcloud max-nextcloud force-pushed the feature/use-viewer-for-singe-file-shares branch from 38503ed to c2c796f Compare July 27, 2022 10:29
@szaimen szaimen added this to the Nextcloud 25 milestone Jul 27, 2022
@szaimen szaimen added the 3. to review Waiting for reviews label Jul 27, 2022
@max-nextcloud max-nextcloud force-pushed the feature/use-viewer-for-singe-file-shares branch from c2c796f to 98a3fef Compare August 1, 2022 09:31
@max-nextcloud max-nextcloud force-pushed the feature/use-viewer-for-singe-file-shares branch 2 times, most recently from fafb98f to 523780a Compare August 11, 2022 09:52
@skjnldsv skjnldsv mentioned this pull request Aug 12, 2022
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@skjnldsv skjnldsv mentioned this pull request Aug 18, 2022
@blizzz blizzz mentioned this pull request Aug 24, 2022
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@PVince81
Copy link
Member

/rebase

@PVince81
Copy link
Member

triggered a rebase to bump CI

@PVince81 PVince81 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 25, 2022
Also bring back the text fallback

Signed-off-by: Max <[email protected]>
Only render images and videos with the viewer.
Text has its own way of handling single file shares for now.

In case viewer does not support the file format
fall back to the old way of handling single file shares.

Signed-off-by: Max <[email protected]>
@nextcloud-command nextcloud-command force-pushed the feature/use-viewer-for-singe-file-shares branch from 523780a to b67aaf7 Compare August 25, 2022 21:59
@PVince81 PVince81 merged commit 264a0bb into master Aug 26, 2022
@PVince81 PVince81 deleted the feature/use-viewer-for-singe-file-shares branch August 26, 2022 07:04
@blizzz blizzz mentioned this pull request Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants