Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Filter out empty IP addresses in dnsResolve method #37778

Closed
wants to merge 1 commit into from

Conversation

w9n
Copy link

@w9n w9n commented Apr 17, 2023

Summary

This commit resolves an issue where empty IP addresses could be returned by the dnsResolve method due to CNAME recursion. The fix filters out empty IP addresses before returning the result, ensuring that only valid, non-empty IP addresses are used in the addDnsPinning method.

TODO

  • ...

Checklist

@szaimen szaimen added this to the Nextcloud 27 milestone Apr 18, 2023
@szaimen szaimen added the 3. to review Waiting for reviews label Apr 18, 2023
@szaimen szaimen requested review from a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team April 18, 2023 00:23
@w9n w9n force-pushed the fixdns branch 2 times, most recently from a67f7a3 to d7827d4 Compare April 18, 2023 09:13
This commit resolves an issue where empty IP addresses could be returned by the dnsResolve method due to CNAME recursion. The fix filters out empty IP addresses before returning the result, ensuring that only valid, non-empty IP addresses are used in the addDnsPinning method.

Signed-off-by: Robin Winkelewski <[email protected]>
@w9n
Copy link
Author

w9n commented Apr 21, 2023

sorry I dont know what exactly went wrong with the php dns resolver here. I guess with the "fix" it just uses curls dns resolver when it didnt work.

This was referenced May 3, 2023
@blizzz blizzz mentioned this pull request May 17, 2023
@blizzz blizzz modified the milestones: Nextcloud 27, Nextcloud 28 May 23, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
@kesselb
Copy link
Contributor

kesselb commented Nov 1, 2023

Thanks for your pull request 👍

Replaced by #40234

@kesselb kesselb closed this Nov 1, 2023
@kesselb kesselb removed this from the Nextcloud 28 milestone Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Applications can't be installed/downloaded - cURL error 49: Couldn't parse CURLOPT_RESOLVE
5 participants