ignore metadata if migration to 28 is not done #41442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArtificialOwl
force-pushed
the
fix/noid/no-join-before-migration
branch
from
911e039
to
d463171
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
ArtificialOwl
force-pushed
the
fix/noid/no-join-before-migration
branch
from
5302036
to
570b906
Compare
ArtificialOwl
force-pushed
the
fix/noid/no-join-before-migration
branch
2 times, most recently
from
db39652
to
175e8cf
Compare
Merged
artonge
approved these changes
Nov 13, 2023
Altahrim
reviewed
Nov 14, 2023
| @@ -214,15 +214,19 @@ public function deleteMetadata(int $fileId): void { | |||
| * @param string $fileIdField alias of the field that contains file ids | |||
| * | |||
| * @inheritDoc | |||
| * @return IMetadataQuery | |||
| * @return IMetadataQuery|null | |||
There was a problem hiding this comment.
The info is already in method signature. We can remove this line.
Signed-off-by: Maxence Lange <[email protected]>
|
You got hit by vimeo/psalm#10316 I think |
Signed-off-by: Maxence Lange <[email protected]>
come-nc
approved these changes
Nov 14, 2023
ArtificialOwl
force-pushed
the
fix/noid/no-join-before-migration
branch
from
e4e1e78
to
761a688
Compare
Altahrim
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since we join the metadata table on
Cache::get(), expect error between upgrade and migration.This fix makes not joining the metadata table until the migration is done