fix: Avoid using replicas during setup #42504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
juliushaertl
requested review from
a team,
ArtificialOwl,
icewind1991 and
Altahrim
and removed request for
a team
bigcat88
approved these changes
Dec 28, 2023
andrey18106
approved these changes
Dec 28, 2023
10 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #41998
It turned out that installation through occ fails if the database that is used has not been created already on the instance as the setup passes over
database => nullto the connection for the installation checks. We need to merge this to the connection params first so that it is part of both the primary and replica configuration.Caused CI failure in tables