Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enh(metadata): store current file etag #42707

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Jan 11, 2024

This PR adds a way to verify if a metadata is up-to-date
This is done by storing the current file etag when setting a new value for a metadata:

{
   "mymeta": {
     "value": "this is a test",
     "type": "string",
     "etag": "abcd1234",
     "indexed": false,
     "editPermission": 1
   },
   "myapp-anothermeta": {
     "value": 42,
     "type": "int",
     "etag": "0987zyxw",
     "indexed": true,
     "editPermission": 0
   }

When called, the method isUpToDate($metadataKey) will compare current file etag with the one stored aside the metadata

(while not mandatory, can be backported to 28)

@ArtificialOwl ArtificialOwl changed the title [wip] store current file etag on metadata [wip] store current file etag at metadata creation Jan 11, 2024
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/store-file-etag-at-metadata-creation branch 3 times, most recently from 6f7dc9d to 88855af Compare January 18, 2024 01:04
@ArtificialOwl ArtificialOwl changed the title [wip] store current file etag at metadata creation enh(metadata): store current file etag Feb 6, 2024
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/store-file-etag-at-metadata-creation branch from 88855af to fbcfa23 Compare February 6, 2024 17:09
@ArtificialOwl ArtificialOwl marked this pull request as ready for review February 6, 2024 17:09
@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label Feb 6, 2024
@ArtificialOwl ArtificialOwl added this to the Nextcloud 29 milestone Feb 6, 2024
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/store-file-etag-at-metadata-creation branch 2 times, most recently from 87b0f57 to c60a6ca Compare February 7, 2024 17:01
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/store-file-etag-at-metadata-creation branch from c60a6ca to 4c4ff75 Compare February 28, 2024 18:28
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Mar 6, 2024
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/store-file-etag-at-metadata-creation branch from 4c4ff75 to 3fa5e59 Compare March 7, 2024 13:49
@ArtificialOwl ArtificialOwl added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 8, 2024
@susnux susnux requested review from a team, icewind1991, Altahrim and Fenn-CS and removed request for a team March 11, 2024 12:32
@ArtificialOwl ArtificialOwl merged commit f4beb95 into master Mar 11, 2024
160 checks passed
@ArtificialOwl ArtificialOwl deleted the enh/noid/store-file-etag-at-metadata-creation branch March 11, 2024 13:46
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants