Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for ignored CSP_NONCE in ContentSecurity Header #43573

Merged
merged 4 commits into from
Aug 13, 2024

Commits on Aug 13, 2024

  1. fix: Use CSP_NONCE env variable in ContentSecurity Header

    We should use 'cspNonceManager' for requesting the NONCE value, because it is doing the same as before, except that it honors a CPS_NONCE environment variable if available.
    
    Signed-off-by: Holger Hees <[email protected]>
    HolgerHees authored and susnux committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    73397cd View commit details
    Browse the repository at this point in the history
  2. fix: Make sure CSP nonce is not double base64 encoded

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    susnux committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    86f01a3 View commit details
    Browse the repository at this point in the history
  3. test: Adjust tests for CSP nonce

    Signed-off-by: Ferdinand Thiessen <[email protected]>
    susnux committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    009761b View commit details
    Browse the repository at this point in the history
  4. feat: Provide CSP nonce as <meta> element

    This way we use the CSP nonce for dynamically loaded scripts.
    Important to notice: The CSP nonce must NOT be injected in `content` as
    this can lead to value exfiltration using e.g. side-channel attacts (CSS selectors).
    
    Signed-off-by: Ferdinand Thiessen <[email protected]>
    susnux committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    2916e5d View commit details
    Browse the repository at this point in the history