Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Convert text to path in f-droid banner SVG #43850

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Feb 26, 2024

Summary

The SVG contains text that only is correctly displayed if the user has the font (Roboto Slap) installed.
So I converted the text to path instead.

Checklist

@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Feb 26, 2024
@susnux susnux added this to the Nextcloud 29 milestone Feb 26, 2024
@susnux susnux requested review from szaimen, a team, sorbaugh and emoral435 and removed request for a team February 26, 2024 16:25
@susnux
Copy link
Contributor Author

susnux commented Feb 26, 2024

/backport to stable28

@susnux
Copy link
Contributor Author

susnux commented Feb 26, 2024

/backport to stable27

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@emoral435
Copy link
Contributor

Nice change :)

@susnux susnux merged commit 250084f into master Feb 27, 2024
98 checks passed
@susnux susnux deleted the fix/f-droid-svg branch February 27, 2024 10:58
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Available on F-Droid svg icon uses text instead of object
3 participants