Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default text processing provider in AI settings #43993

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

julien-nc
Copy link
Member

When no AI setting has been set, make sure the selected text processing provider is the same as the one that will be actually used by the manager.

The manager takes the first available provider from its getProviders method result. The settings were showing the last in this list.

refs nextcloud/text#5269 (comment)

Also, add provider name in results of fake providers (in the testing app).

I didn't check but we might have the same problem for STT, text2image and translation.

@julien-nc julien-nc force-pushed the fix/noid/ai-settings-default-tp-provider branch from 24b5925 to 0b4afe6 Compare March 5, 2024 13:09
@julien-nc julien-nc enabled auto-merge March 5, 2024 13:24
This was referenced Mar 12, 2024
@julien-nc julien-nc force-pushed the fix/noid/ai-settings-default-tp-provider branch from 0b4afe6 to 75127f2 Compare March 15, 2024 11:54
…cessing provider is the same as the one that will be used

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc force-pushed the fix/noid/ai-settings-default-tp-provider branch from 75127f2 to ba94de2 Compare March 15, 2024 12:17
@julien-nc julien-nc merged commit 7af282d into master Mar 15, 2024
167 checks passed
@julien-nc julien-nc deleted the fix/noid/ai-settings-default-tp-provider branch March 15, 2024 15:15
@julien-nc
Copy link
Member Author

/backport to stable28

Copy link

backportbot bot commented Mar 18, 2024

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b backport/43993/stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ba94de25

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/43993/stable28

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants