Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "files_versions: add missing null check" #44083

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Mar 8, 2024

Reverts #44066

@artonge artonge added 4. to release Ready to be released and/or waiting for tests to finish feature: versions labels Mar 8, 2024
@artonge artonge requested review from susnux and emoral435 March 8, 2024 10:33
@artonge artonge self-assigned this Mar 8, 2024
@artonge artonge added this to the Nextcloud 29 milestone Mar 8, 2024
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the problem? I mean with or without both is ok 😅

@Pytal
Copy link
Member

Pytal commented Mar 8, 2024

What is the problem? I mean with or without both is ok 😅

Probably better to log the error than silently suppress to catch potential bugs @artonge?

@artonge
Copy link
Contributor Author

artonge commented Mar 8, 2024

What is the problem? I mean with or without both is ok 😅

I am not comfortable silencing an error without fixing its cause.

Probably better to log the error than silently suppress to catch potential bugs @artonge?

We could throw an error, but that is what is already happening down the line and that won't fix the issue.

@artonge artonge enabled auto-merge March 8, 2024 11:20
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an interesting bug - we get path from either the currently logged in user, or the owner of the version. If not either of them, then we return null... but who else can edit a file? It's interesting, but after seeing the commits body message, I agree that having something in check without giving it a bandaid fix is good :)

@artonge artonge merged commit 1c0191a into master Mar 8, 2024
160 checks passed
@artonge artonge deleted the revert-44066-pulsejet/ver-nc branch March 8, 2024 13:22
@Altahrim Altahrim mentioned this pull request Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: versions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants