-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support "s3-accelerate" endpoint #44496
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
requested review from
a team,
ArtificialOwl,
Fenn-CS and
sorbaugh
and removed request for
a team
March 26, 2024 18:00
Relevant issue: #42675 |
Merged
Will this handle also:
? |
Hi solracsf, this PR doesn't handle dualstack atm |
icewind1991
force-pushed
the
feat/s3-accelerate
branch
from
April 23, 2024 11:30
81ceba8
to
6580f09
Compare
added dualstack support |
🤩 |
artonge
approved these changes
Apr 24, 2024
sorbaugh
approved these changes
Apr 25, 2024
Signed-off-by: Robin Appelman <[email protected]>
icewind1991
force-pushed
the
feat/s3-accelerate
branch
from
April 26, 2024 12:40
6580f09
to
40d9a3f
Compare
/backport to stable29 |
/backport to stable28 |
/backport to stable27 |
joshtrichards
added a commit
that referenced
this pull request
Jun 3, 2024
Fixes #45637 The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated). Signed-off-by: Josh <[email protected]>
5 tasks
joshtrichards
added a commit
that referenced
this pull request
Jun 3, 2024
Fixes #45637 The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated). Signed-off-by: Josh <[email protected]>
joshtrichards
added a commit
that referenced
this pull request
Jun 3, 2024
Fixes #45637 The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated). Signed-off-by: Josh <[email protected]>
joshtrichards
added a commit
that referenced
this pull request
Jun 4, 2024
Fixes #45637 The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated). Signed-off-by: Josh <[email protected]>
kesselb
pushed a commit
that referenced
this pull request
Jun 12, 2024
Fixes #45637 The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated). Signed-off-by: Josh <[email protected]>
joshtrichards
added a commit
that referenced
this pull request
Jun 12, 2024
Fixes #45637 The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated). Signed-off-by: Josh <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
Fixes #45637 The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated). Signed-off-by: Josh <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
Fixes #45637 The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated). Signed-off-by: Josh <[email protected]>
backportbot bot
pushed a commit
that referenced
this pull request
Jun 12, 2024
Fixes #45637 The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated). Signed-off-by: Josh <[email protected]>
susnux
pushed a commit
that referenced
this pull request
Jun 13, 2024
Fixes #45637 The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated). Signed-off-by: Josh <[email protected]>
kesselb
pushed a commit
that referenced
this pull request
Jun 13, 2024
Fixes #45637 The support for s3-accelerate added in #44496 introduced a regression in AWS S3 environments when `hostname` is blank (which is a valid configuration w/ AWS since the hostname gets auto-generated). Signed-off-by: Josh <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the S3 hostname is set to
s3-accelerate.amazonaws.com
, enable theuse_accelerate_endpoint
.