Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(files): Inherit some node attributes when creating new nodes to preserve shared state #44834

Merged
merged 3 commits into from
Apr 16, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Apr 15, 2024

Summary

When creating new nodes (e.g. new text file or folder) then we also need to inherit some attributes in the first node version before loading from backend. Otherwise files created in folders shared with you will not be shown as shared.

Checklist

@susnux susnux requested review from artonge and a team April 15, 2024 16:15
@susnux susnux requested a review from skjnldsv as a code owner April 15, 2024 16:15
@susnux susnux requested review from szaimen and emoral435 and removed request for a team April 15, 2024 16:15
@susnux
Copy link
Contributor Author

susnux commented Apr 15, 2024

/backport to stable29

@susnux
Copy link
Contributor Author

susnux commented Apr 15, 2024

/backport to stable28

@susnux susnux added this to the Nextcloud 30 milestone Apr 15, 2024
@susnux susnux changed the title Fix/files new nodes attributes fix(files): Inherit some node attributes when creating new nodes to preserve shared state Apr 15, 2024
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small suggestion aside, this is a good PR! :)

apps/files/src/views/TemplatePicker.vue Outdated Show resolved Hide resolved
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Eduardo's comment make sense.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: When I create a file in a shared folder, it is shown as not shared
3 participants