[stable28] fix: Refresh file picker on folder creation #45575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pytal
added
bug
3. to review
Pytal
changed the title
pulsejet
approved these changes
May 29, 2024
There was a problem hiding this comment.
Didn't test but still seems good. Was bound to happen at some point #41202 (comment)
skjnldsv
approved these changes
May 30, 2024
susnux
reviewed
May 30, 2024
Pytal
force-pushed
the
fix/new-folder-refresh
branch
2 times, most recently
from
f06e859
to
cdc2521
Compare
Signed-off-by: Christopher Ng <[email protected]>
1. Refresh token on update 2. Fix some very weird imports 3. Patch fetch instead of request to prevent accessing impl details Signed-off-by: Varun Patil <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Pytal
force-pushed
the
fix/new-folder-refresh
branch
from
cdc2521
to
837b246
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To fix the bug we bring in the updated new folder functionality from the dialogs lib. After bumping there is a new cannot read "authType" error which comes from within the webdav lib. This errors because we patch the internal
request()ofwebdavand the function definition changed in perry-mitchell/webdav-client#370. Instead we patch fetch by backporting the commit from #41202Checklist