Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set default TTL for APCu cache as per docs #46395

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Conversation

icewind1991
Copy link
Member

Make the method behavior match the description

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 10, 2024
@icewind1991 icewind1991 added this to the Nextcloud 30 milestone Jul 10, 2024
@icewind1991 icewind1991 requested review from nickvergessen, juliusknorr, a team, ArtificialOwl, yemkareems and sorbaugh and removed request for a team July 10, 2024 10:44
lib/public/ICache.php Fixed Show fixed Hide fixed
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Memcached seems to have the same problem?

Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple thoughts:

  • Should we do this for inc and dec too? e.g. https://www.php.net/manual/en/function.apcu-inc.php
  • Should we adjust the logging wrapper to include the ttl at the same time?
  • Probably out of scope, but may also be an opportunity clean-up the no longer needed code for an early PHP 7 bug in inc & dec a bit farther down

@icewind1991
Copy link
Member Author

  • clarified the documentation for inc and dec and cleanup up the implementation now that all supported versions behave the same

lib/public/ICache.php Fixed Show fixed Hide fixed
@SystemKeeper
Copy link
Contributor

SystemKeeper commented Jul 11, 2024

  • clarified the documentation for inc and dec and cleanup up the implementation now

Is it correct that you removed the comment from dec but did not change the implementation? (Only for inc)?

Seems the documentation is also different.

@icewind1991 icewind1991 merged commit 495f454 into master Aug 7, 2024
169 checks passed
@icewind1991 icewind1991 deleted the apcu-default-ttl branch August 7, 2024 18:16
@solracsf
Copy link
Member

This is causing troubles on v30: #48007

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants