Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] Fix status check and saving of external storages #47734

Merged
merged 11 commits into from
Sep 5, 2024
Merged

[stable29] Fix status check and saving of external storages #47734

merged 11 commits into from
Sep 5, 2024

Commits on Sep 4, 2024

  1. refactor: Store result in its own variable 

    Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu @AndyScherzinger
    danxuliu authored and AndyScherzinger committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    80f038c View commit details
    Browse the repository at this point in the history

  2. fix: Recheck userglobal storages when loaded 

    Userglobal storages are now automatically recheck when loaded, similarly
to how it is done for global storages.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu @AndyScherzinger
    danxuliu authored and AndyScherzinger committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    b71da3d View commit details
    Browse the repository at this point in the history

  3. fix: Remove status check when configuration was changed 

    Setting a null status was supposed to remove the status check, but
nothing was changed in that case. Now the status check is properly
removed, and doing that by hiding the element rather than just turning
it invisible also prevents that clicking on the invisible status
triggers a check, as until the new configuration is saved the check will
still be performed with the old configuration, which could be misleading
for the user.

Additionally, an explicit width is set to the parent of the span element
to prevent its width from changing when the span is shown and hidden.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu @AndyScherzinger
    danxuliu authored and AndyScherzinger committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    8d3ff42 View commit details
    Browse the repository at this point in the history

  4. fix: Set status tooltip to status message when saving an storage 

    When a storage is saved the status check can fail even if saving the
storage succeeds. In those cases further details are provided in the
status message of the storage, which is now set as the tooltip,
similarly to how it is done when rechecking the storage.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu @AndyScherzinger
    danxuliu authored and AndyScherzinger committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    caa7936 View commit details
    Browse the repository at this point in the history

  5. fix: Set status tooltip to error message on failed actions 

    When saving, updating and rechecking an storage fails (which is
different to the soft-fail when the action itself succeeds but the
status check does not) further details are provided in the error message
of the response, which is now set as the tooltip.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu @AndyScherzinger
    danxuliu authored and AndyScherzinger committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    981a20e View commit details
    Browse the repository at this point in the history

  6. fix: Restore default status tooltip when no status message is provided 

    If the status is updated but no explicit message is provided (for
example, if the status check succeeded) the default tooltip (from the
template) is now set to prevent a mismatch between the status and the
tooltip (for example, if the configuration is fixed after a failed
status check).

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu @AndyScherzinger
    danxuliu authored and AndyScherzinger committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    cdc64d1 View commit details
    Browse the repository at this point in the history

  7. fix: Add missing translation for UI string 

    Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu @AndyScherzinger
    danxuliu authored and AndyScherzinger committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    8a97029 View commit details
    Browse the repository at this point in the history

  8. fix: Reset selected backend when adding a new storage 

    As a new storage is added by selecting a backend the selected backend
needs to be reset. Otherwise it is not possible to add another storage
with the same backend.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu @AndyScherzinger
    danxuliu authored and AndyScherzinger committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    66c6890 View commit details
    Browse the repository at this point in the history

  9. test: Add integration tests for saving external userglobal storages 

    As the external storage uses the Nextcloud server itself the number of
workers of the PHP process running the Nextcloud server had to be
increased. Otherwise if a request is sent for the external storage while
handling a request from the integration tests a deadlock would occur.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu @AndyScherzinger
    danxuliu authored and AndyScherzinger committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    f34daed View commit details
    Browse the repository at this point in the history

  10. fix: Fix unmodified placeholder replacing the actual value when updating 

    When updating global storages and user storages a property is not
updated by "StoragesService::updateStorage()" if the value matches the
unmodified placeholder. However, userglobal storages are not updated
through the "StoragesService"; as only the authentication mechanism is
updated it is directly done with "saveBackendOptions()" in
"IUserProvided" or "UserGlobalAuth". Due to this the unmodified
placeholder value needs to be explicitly checked in those cases and
replaced by the actual value (note that in this case it is not possible
to just skip updating a specific property).

Signed-off-by: Daniel Calviño Sánchez <[email protected]>
    @danxuliu @AndyScherzinger
    danxuliu authored and AndyScherzinger committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    5ed377e View commit details
    Browse the repository at this point in the history

  11. fix: Hide status tooltip in row to add a new mount point 

    The row to add a new mount point is cloned when a new mountpoint is

added, so it is expected that it includes a status span. However, it

should not be displayed in that row, only in the cloned row when its

status is updated.

Signed-off-by: Daniel Calviño Sánchez <[email protected]>

Signed-off-by: nextcloud-command <[email protected]>
    @danxuliu @AndyScherzinger
    danxuliu authored and AndyScherzinger committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    8445050 View commit details
    Browse the repository at this point in the history