Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theming): Use AppConfig for setting background image #48439

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Sep 28, 2024

Summary

We need to use the AppConfig consistently otherwise it will hard-fail like it does currently.

Checklist

@susnux susnux requested review from kesselb, a team, ArtificialOwl, yemkareems and come-nc and removed request for a team September 28, 2024 20:48
@susnux susnux added this to the Nextcloud 31 milestone Sep 28, 2024
@susnux
Copy link
Contributor Author

susnux commented Sep 28, 2024

/backport to stable30

Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@kesselb kesselb merged commit be87dec into master Sep 30, 2024
173 checks passed
@kesselb kesselb deleted the fix/background-image branch September 30, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants