Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reactions notifications when fully subscribed in federated conversations #11857

Open
nickvergessen opened this issue Mar 19, 2024 · 0 comments · May be fixed by #13183
Open

Reactions notifications when fully subscribed in federated conversations #11857

nickvergessen opened this issue Mar 19, 2024 · 0 comments · May be fixed by #13183
Labels
1. to develop bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 feature: reactions 👍 good first issue
Milestone
💚 Next Patch (29)

Comments

@nickvergessen
Copy link
Member

nickvergessen commented Mar 19, 2024 •
edited
Loading

In a federated conversations users do not receive notifications when they change the notification level to "always" and a reaction is done

Normal chats are handled in:

spreed/lib/Chat/Notifier.php

Lines 269 to 300 in 1ccbf67

public function notifyReacted(Room $chat, IComment $comment, IComment $reaction): void {
if ($comment->getActorType() !== Attendee::ACTOR_USERS) {
return;
}
if ($comment->getActorType() === $reaction->getActorType() && $comment->getActorId() === $reaction->getActorId()) {
return;
}
try {
$participant = $this->participantService->getParticipant($chat, $comment->getActorId(), false);
} catch (ParticipantNotFoundException $e) {
return;
}
$notificationLevel = $participant->getAttendee()->getNotificationLevel();
if ($notificationLevel === Participant::NOTIFY_DEFAULT) {
if ($chat->getType() === Room::TYPE_ONE_TO_ONE) {
$notificationLevel = Participant::NOTIFY_ALWAYS;
} else {
$notificationLevel = $this->getDefaultGroupNotification();
}
}
if ($notificationLevel === Participant::NOTIFY_ALWAYS) {
$notification = $this->createNotification($chat, $comment, 'reaction', [
'reaction' => $reaction->getMessage(),
], $reaction);
$notification->setUser($comment->getActorId());
$this->notificationManager->notify($notification);
}
}

And something alike should happen in

spreed/lib/Federation/Proxy/TalkV1/Notifier/MessageSentListener.php

Line 32 in 1ccbf67

class MessageSentListener implements IEventListener {

By "analysing" the system messages for reaction adding
@nickvergessen nickvergessen added this to the 💞 Next Beta (29) milestone Mar 19, 2024
@nickvergessen nickvergessen added 1. to develop feature: chat 💬 Chat and system messages feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 feature: reactions 👍 bug and removed feature: chat 💬 Chat and system messages labels Mar 19, 2024
@nickvergessen nickvergessen changed the title Reactions notifications when fully subscribed Reactions notifications when fully subscribed in federated conversations May 2, 2024
@nickvergessen nickvergessen mentioned this issue May 13, 2024
Merged
5 tasks
@skalidindi53 skalidindi53 self-assigned this Jun 13, 2024
@skalidindi53 skalidindi53 removed their assignment Jun 14, 2024
@skalidindi53 skalidindi53 linked a pull request Aug 29, 2024 that will close this issue
Draft
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. to develop bug feature: api 🛠️ OCS API for conversations, chats and participants feature: federation 🌐 feature: reactions 👍 good first issue
Projects
None yet
Milestone
💚 Next Patch (29)
Development

Successfully merging a pull request may close this issue.

feat; Reactions notifications in fully subscribed federated convos nextcloud/spreed
4 participants
@nickvergessen @DorraJaouad @Antreesy @skalidindi53