-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Call): introduce intermediary phase before joining call #13329
base: main
Are you sure you want to change the base?
Conversation
setTimeout(() => { | ||
// If by accident we never receive a users list, just switch to | ||
// "Waiting for others to join the call …" after some seconds. | ||
commit('finishedConnecting', { token, sessionId: participantIdentifier.sessionId }) | ||
}, 10000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's guaranteed to receive one of the above signaling events as we are the base server
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that finishedConnecting
does not mean It was possible to join the call
, but After joining the call, the list of participants in the call was received
. Therefore this change breaks its behaviour.
After joining a call without HPB Connecting was shown in the call view until the list of participants in the call was received. If there were no other participants in the call Connecting was replaced by Waiting for others to join the call, and if there were other participants then a connection was established with them. Now, if there are other participants, Waiting for others to join the call will be briefly shown until the participant list is received, which is not correct.
If there is HPB, however, the Connecting state was wrong, as usersInRoom
is never triggered in that case (probably usersChanged
should have been used instead) 🤷 So Connecting was shown for ten seconds when there were no other participants in the call.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works good in general, but I'd test it in some real calls before merging
|
…t. It's only received when using internal server. Replace them with events from the base class so we make sure it's always received. Also, add a new event for failed joining Signed-off-by: DorraJaouad <[email protected]>
…nCall, connecting, connection failed) Signed-off-by: DorraJaouad <[email protected]>
f700fed
to
1191f69
Compare
It was because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, looks and works fine
Let's wait for @danxuliu opinion on that
…roduce a failed join message dialog. Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
1191f69
to
40205de
Compare
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
Before
Recording.2024-09-17.160718.mp4
After
Recording.2024-09-17.160913.mp4
🏁 Checklist