Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(callView): move store to Pinia 🍍 #13432

Merged
merged 5 commits into from
Oct 14, 2024
Merged

Commits on Oct 14, 2024

  1. fix(callView): move logic from Vuex to Pinia

    Signed-off-by: Maksim Sukharev <[email protected]>
    Antreesy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    1fbb4a8 View commit details
    Browse the repository at this point in the history
  2. fix: refactor getters

    - forceCallView
    - isViewerOverlay
    - isGrid
    - isStripeOpen
    - isEmptyCallView
    - lastIsGrid
    - lastIsStripeOpen
    - presentationStarted
    - selectedVideoPeerId
    - callHasJustEnded
    
    Signed-off-by: Maksim Sukharev <[email protected]>
    Antreesy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    da9b0f4 View commit details
    Browse the repository at this point in the history
  3. fix: remove redundant and unrelated getters

    - remove isQualityWarningTooltipDismissed from store (reset on each call, so make sense to store in component only)
    - move participantRaisedHands to participantsStore
    - remove backgroundImageAverageColorCache from store (was dropped in 9094628)
    
    Signed-off-by: Maksim Sukharev <[email protected]>
    Antreesy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    9780820 View commit details
    Browse the repository at this point in the history
  4. fix: refactor actions

    - handleJoinCall
    - setCallViewMode
    - startPresentation
    - stopPresentation
    
    Signed-off-by: Maksim Sukharev <[email protected]>
    Antreesy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    d203d1f View commit details
    Browse the repository at this point in the history
  5. fix: adjust tests for callView store

    - increase coverage
    
    Signed-off-by: Maksim Sukharev <[email protected]>
    Antreesy committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    5ae2352 View commit details
    Browse the repository at this point in the history