Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: omit 'with 0 guests' in system messages when call ends #13545

Merged
merged 2 commits into from
Oct 14, 2024

Conversation

Antreesy
Copy link
Contributor

☑️ Resolves

  • Add translations for ''0 guests' cases

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
2024-10-14_14h44_07 image

🛠️ API Checklist

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not possible
  • 📘 API documentation in docs/ has been updated or is not required
  • 🔖 Capability is added or not needed

@Antreesy Antreesy added 3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls labels Oct 14, 2024
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Oct 14, 2024
@Antreesy Antreesy self-assigned this Oct 14, 2024
Base automatically changed from feat/13463/force-end-call to main October 14, 2024 13:25
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nickvergessen
Copy link
Member

/backport to stable30

@nickvergessen nickvergessen merged commit 2fa9f94 into main Oct 14, 2024
68 checks passed
@nickvergessen nickvergessen deleted the feat/noid/end-call-0-guests branch October 14, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review feature: api 🛠️ OCS API for conversations, chats and participants feature: call 📹 Voice and video calls
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants