Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix(callView): move store to Pinia 🍍 #13546

Merged
merged 5 commits into from
Oct 14, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 14, 2024

Backport of #13432

(clean backport, rebased)

Signed-off-by: Maksim Sukharev <[email protected]>
(cherry picked from commit 1fbb4a8)
- forceCallView
- isViewerOverlay
- isGrid
- isStripeOpen
- isEmptyCallView
- lastIsGrid
- lastIsStripeOpen
- presentationStarted
- selectedVideoPeerId
- callHasJustEnded

Signed-off-by: Maksim Sukharev <[email protected]>
(cherry picked from commit da9b0f4)
- remove isQualityWarningTooltipDismissed from store (reset on each call, so make sense to store in component only)
- move participantRaisedHands to participantsStore
- remove backgroundImageAverageColorCache from store (was dropped in 9094628)

Signed-off-by: Maksim Sukharev <[email protected]>
(cherry picked from commit 9780820)
- handleJoinCall
- setCallViewMode
- startPresentation
- stopPresentation

Signed-off-by: Maksim Sukharev <[email protected]>
(cherry picked from commit d203d1f)
- increase coverage

Signed-off-by: Maksim Sukharev <[email protected]>
(cherry picked from commit 5ae2352)
@Antreesy Antreesy marked this pull request as ready for review October 14, 2024 15:48
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

@Antreesy Antreesy merged commit d48acc2 into stable30 Oct 14, 2024
47 of 48 checks passed
@Antreesy Antreesy deleted the backport/13432/stable30 branch October 14, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant