Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chat): disable smooth scroll to bottom #13572

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Oct 17, 2024

☑️ Resolves

  • disable smooth scroll to bottom
  • update previous scroll position in scroll event (not after it's finished)
  • store direction while scrolling
  • ensure debounceHandleScroll is fired before endScroll

🖌️ UI Checklist

🖼️ Screenshots / Screencasts

🏚️ Before 🏡 After
2024-10-17_16h55_35 2024-10-17_16h53_46

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team

- update previous scroll position in scroll event (not after it's finished)
- store direction while scrolling
- ensure debounceHandleScroll is fired before endScroll

Signed-off-by: Maksim Sukharev <[email protected]>
@Antreesy Antreesy added this to the 🖤 Next Major (31) milestone Oct 17, 2024
@Antreesy Antreesy self-assigned this Oct 17, 2024
@Antreesy
Copy link
Contributor Author

I know that smooth: false is default, just not sure if we keep it or bring back later, so want to explicit that it's disabled

@DorraJaouad
Copy link
Contributor

Please state the reason why we disable smooth scroll to bottom so we would be aware of any issues :p.

@nickvergessen
Copy link
Member

Please state the reason why we disable smooth scroll to bottom so we would be aware of any issues :p.

Can even link to the original issue or PR, so you have the reference videos :)

@DorraJaouad
Copy link
Contributor

Can even link to the original issue or PR, so you have the reference videos :)

Still not evident that it fixes this issue 100%, it increased the speed of down scrolling so the widget scrolling workaround and the down scrolling will unlikely overlap.

@Antreesy
Copy link
Contributor Author

widget scrolling workaround

Still going to work with user wheel-scrolling

why we disable smooth scroll

  • Less load on client to draw animation frames
  • Skip observer checks for widgets (if they're working), so we don't trigger their render

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Scroll to bottom" does not scroll all the way
3 participants