Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement dashboard IAPIWidget #7942

Merged
merged 6 commits into from
Sep 20, 2022
Merged

Implement dashboard IAPIWidget #7942

merged 6 commits into from
Sep 20, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 16, 2022 •
edited
Loading

Fix #7867

  • Implement IAPIWidget
  • Implement IIconWidget
  • Should we also implement IButtonWidget ?

@nickvergessen nickvergessen added 3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants labels Sep 16, 2022
@nickvergessen nickvergessen added this to the 💚 Next RC (25) milestone Sep 16, 2022
vitormattos
vitormattos reviewed Sep 16, 2022
View reviewed changes
Copy link
Contributor

@vitormattos vitormattos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't good to implement test scenarios to cover this code and check if to specific room list will return the specific items?

@nickvergessen
Copy link
Member Author

Isn't good to implement test scenarios to cover this code

I was thinking about it as well.
My main issue is that integration tests go against API of the dashboard app. Also the result is polluted heavily depending on the enabled apps. But sure let me check

@nickvergessen
Implement dashboard IAPIWidget
ee2807b 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Implement IIconWidget
6400a04 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add options and buttons
7d839d8 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Add integration tests for dashboard data
f2482bc 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Execute the test on CI
73033ce 
Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen
Copy link
Member Author

Added integration tests

tobiasKaminsky
tobiasKaminsky reviewed Sep 20, 2022
View reviewed changes
lib/Dashboard/TalkWidget.php
$subtitle,
$this->url->linkToRouteAbsolute('spreed.Page.showCall', ['token' => $room->getToken()]),
$this->getRoomIconUrl($room, $userId)
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add here roundIcon: true

https:/nextcloud/server/blob/master/lib/public/Dashboard/Model/WidgetOptions.php#L32
it is in
Widget Options:
https:/nextcloud/server/blob/master/lib/public/Dashboard/IOptionWidget.php#L37

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Items itself don't have the options and the widget itself already has the "roundIcon" option set.
https:/nextcloud/spreed/pull/7942/files#diff-9d0ac71d126947c6f952b00aba3afc1df1e75b99431cb53086b0c43c2f677c29R90

@nickvergessen nickvergessen merged commit 4577103 into master Sep 20, 2022
@nickvergessen nickvergessen deleted the feature/noid/dashboard-api branch September 20, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky left review comments

@vitormattos vitormattos vitormattos approved these changes

Assignees
No one assigned
Labels
3. to review enhancement feature: api 🛠️ OCS API for conversations, chats and participants
Projects
None yet
Milestone
v15.0.0-rc.1
Development

Successfully merging this pull request may close these issues.

Adapt talk mentions widget for mobile clients
3 participants
@nickvergessen @vitormattos @tobiasKaminsky