Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix participant popover design #2244

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Fix participant popover design #2244

merged 1 commit into from
Apr 6, 2022

Conversation

juliusknorr
Copy link
Member

Contributes to #1075

  • Always show all participants in dropdown (including yourself so you know your own color)
  • Do not show own entry for guests (as there we have the name picker)
  • Change tooltip to just say "Participants"
  • Align avatars of the list with the guest name editor

Screenshot 2022-03-16 at 16 00 29

@juliusknorr
Copy link
Member Author

/compile amend /

@juliusknorr
Fix participant popover design
9d3ab90 
Signed-off-by: Julius Härtl <[email protected]>
@juliusknorr
Copy link
Member Author

Switched to the latest 14.x node version, lets see if that makes the build asset ci happy

@juliusknorr juliusknorr merged commit b8c3de8 into master Apr 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the enh/session-list branch April 6, 2022 18:21
@blizzz blizzz mentioned this pull request Apr 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinicius73 vinicius73 vinicius73 approved these changes

@luka-nextcloud luka-nextcloud Awaiting requested review from luka-nextcloud

@max-nextcloud max-nextcloud Awaiting requested review from max-nextcloud

Assignees
No one assigned
Labels
3. to review design: papercut
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliusknorr @vinicius73