Skip to content

Commit

Permalink
Merge pull request #526 from nextcloud/fix/master-is-29
Browse files Browse the repository at this point in the history
Change master version to 29 in tests
  • Loading branch information
blizzz authored Jan 25, 2024
2 parents 4d660d8 + 80ffaed commit 04a25b3
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
4 changes: 0 additions & 4 deletions index.php
Original file line number Diff line number Diff line change
Expand Up @@ -1284,7 +1284,6 @@ public function isAuthenticated(): bool {
if (isset($_POST['step'])) {
// mark step as failed
http_response_code(500);
header('Content-Type: application/json');
echo(json_encode(['proceed' => false, 'response' => $e->getMessage()]));
die();
}
Expand Down Expand Up @@ -1371,7 +1370,6 @@ public function isAuthenticated(): bool {
break;
}
$updater->endStep($step);
header('Content-Type: application/json');
echo(json_encode(['proceed' => true]));
} catch (UpdateException $e) {
$data = $e->getData();
Expand All @@ -1387,7 +1385,6 @@ public function isAuthenticated(): bool {
$updater->rollbackChanges($step);
}
http_response_code(500);
header('Content-Type: application/json');
echo(json_encode(['proceed' => false, 'response' => $data]));
} catch (\Exception $e) {
$message = $e->getMessage();
Expand All @@ -1403,7 +1400,6 @@ public function isAuthenticated(): bool {
$updater->rollbackChanges($step);
}
http_response_code(500);
header('Content-Type: application/json');
echo(json_encode(['proceed' => false, 'response' => $message]));
}

Expand Down
2 changes: 1 addition & 1 deletion tests/features/master.feature
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,6 @@ Feature: CLI updater - master base
And the version number is decreased in the config.php to enforce upgrade
When the CLI updater is run successfully
And the output should contain "Update successful"
Then the installed version should be 28.0
Then the installed version should be 29.0
And maintenance mode should be off
And upgrade is not required
Binary file modified updater.phar
Binary file not shown.

0 comments on commit 04a25b3

Please sign in to comment.