Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not create new section for data migration in settings #401

Closed
Niveshkrishna opened this issue Apr 27, 2023 · 8 comments · Fixed by #771
Closed

Do not create new section for data migration in settings #401

Niveshkrishna opened this issue Apr 27, 2023 · 8 comments · Fixed by #771
Assignees

Comments

@Niveshkrishna
Copy link

If there's a section already defined with data migration do not add a new section with same name. For example, when we have google integration app enabled in nextcloud, it creates an item to section with name Data migration and now when we enable this app, we have two Data migration sections in settings.

Please merge them and create a single data migration section in settings as this will avoid confusion.

image

@Niveshkrishna
Copy link
Author

We basically have to change this line

return Application::APP_ID;

to

return 'migration'

@Pytal
Copy link
Member

Pytal commented Apr 28, 2023

🤔 that would group user_migration with the unrelated cloud integration integration_* apps (query)

Best option would probably be to use different names for the sections

How should we name these sections distinctly @jancborchardt?

@Niveshkrishna
Copy link
Author

@Pytal integration_* apps basically imports data from other cloud services into nextcloud, and this app allow import and export functionality within nextcloud. IMO both of them can be clubbed into same section.

@jancborchardt
Copy link
Member

integration_* apps basically imports data from other cloud services into nextcloud, and this app allow import and export functionality within nextcloud. IMO both of them can be clubbed into same section.

Yeah, from a user perspective import/export, whether it is internal or external can be treated the same. :) @Pytal we can group it in the same section.

@jancborchardt
Copy link
Member

And the icon can be the "person" one, the lowest entry in this screenshot by @Niveshkrishna: #401 (comment)

@Pytal
Copy link
Member

Pytal commented Jun 8, 2023

How should we order the settings themselves @jancborchardt? Should it be user_migration settings first then integration_* or the other way around?

@JimmyKater
Copy link

isn't it completely irrelevant how it's sorted?
I mean just do it... it seems to be a single and easy change to make. And though it tooks almost a year to implement it because you wait for someone to answer on it taking into account that up to now there are two sections with the same name?

What do you think is worse: two sections by the same name confusing the user or maybe a wrong sorting within one section (which could be solved in a 2nd step if neccessary)?

I'd go with the first one.

Other than that @Pytal thanks for replying (and closing) to my other issue. I didn't find this one here while searching for it.

@jancborchardt
Copy link
Member

@Pytal if it’s still relevant: First integration, then migration, then deletion. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants