Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File picker filter by export extension #109

Merged
merged 2 commits into from
Apr 14, 2022
Merged

Conversation

PVince81
Copy link
Member

@PVince81 PVince81 commented Apr 14, 2022

The file picker now only display files with the extension
".nextcloud_export"

@PVince81 PVince81 added the 3. to review Waiting for reviews label Apr 14, 2022
@PVince81 PVince81 requested review from Pytal and come-nc April 14, 2022 09:07
@PVince81 PVince81 self-assigned this Apr 14, 2022
@PVince81 PVince81 added this to the 0.1 milestone Apr 14, 2022
@PVince81
Copy link
Member Author

/compile amend /

@PVince81
Copy link
Member Author

@Pytal can you take over ? for the clean approach we need to go through nextcloud-dialogs and extend it there, which is a longer detour but will need to be done eventually

@Pytal
Copy link
Member

Pytal commented Apr 14, 2022

@PVince81 I can take over this one, do you want to release this now and https:/nextcloud/nextcloud-dialogs for 0.2?

PVince81 and others added 2 commits April 14, 2022 18:37
The file picker now only display files with the extension
".nextcloud_export"

Signed-off-by: Vincent Petry <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
@Pytal Pytal force-pushed the enh/noid/filepicker-filter branch from f3b1be2 to 2f32b73 Compare April 14, 2022 18:47
@Pytal Pytal merged commit 498b4db into main Apr 14, 2022
@Pytal Pytal deleted the enh/noid/filepicker-filter branch April 14, 2022 18:54
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 14, 2022
@Pytal
Copy link
Member

Pytal commented Apr 14, 2022

Issue opened to add filter to https:/nextcloud/nextcloud-dialogs package nextcloud-libraries/nextcloud-dialogs#560

@Pytal
Copy link
Member

Pytal commented Apr 14, 2022

Everything for milestone 1.0 is in and released in v1.0.1-beta.2 #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants