Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[talk] Nextcloud Talk High Performance Back-end repo will change it's structure #2392

Closed
morph027 opened this issue Sep 4, 2022 · 11 comments
Labels

Comments

@morph027
Copy link
Collaborator

morph027 commented Sep 4, 2022

Steps To Reproduce

Run apt-get update.

Expected Result

apt-get update finishes without error.

Actual Result

apt-get update finishes with error.

N: This must be accepted explicitly before updates for this repository can be applied. See apt-secure(8) manpage for details.

Screenshots, Videos, or Pastebins

No response

Additional Context

Not active yet, will happen with the next upstream or bugfix release

Announcement: https://gitlab.com/packaging/nextcloud-spreed-signaling/-/issues/5

Build Version

n/a

Environment

By using the scripts

Environment Details

No response

@morph027 morph027 added the bug label Sep 4, 2022
@morph027
Copy link
Collaborator Author

morph027 commented Sep 4, 2022

Not sure how to handle this. Adding apt-get update --allow-releaseinfo-change is insecure and should be executed manually, which is not ideal.

Does the VM have any possibility to announce news or notifications to the users? (motd, nextcloud notifications, ...)

@enoch85
Copy link
Member

enoch85 commented Sep 4, 2022

Question is why you decided to change your repo in the first place? Is it so important that thousands of users won't be able to run 'apt-update' without an error?

@morph027
Copy link
Collaborator Author

morph027 commented Sep 4, 2022

Reason was to allow the repo to be flagged properly for unattended-upgrades, which requires these fields. Also, it adheres to best practices to supply them. Unfortunately, i forgot to add them in the past, which leads to this hassle now.

If a user runs apt-get update manually, i'll ask for the change to be committed, so no problem from this side. I've also created an issue in my repo to notice anyone who stumbles upon this.

It's just annoying when being used in non-interactive scripts. That's why i created this issue here, so hopefully everybody who runs into this get's the info.

@enoch85
Copy link
Member

enoch85 commented Sep 9, 2022

@morph027 We could automatically accept it if TURN is installeld by adding a -y flag, right?

@morph027
Copy link
Collaborator Author

morph027 commented Sep 9, 2022

Installation from scratch would work without any issues. Updating an existing installation will suffer the problem mentioned, but will work if the user runs apt-get update --allow-releaseinfo-change

Just using -yflag does not work. Also it does not affect the TURN server but the nextcloud-spreed-signalingpackage.

@enoch85
Copy link
Member

enoch85 commented Sep 22, 2022

We can check if TURN is installed during update, and just force it with apt-get update --allow-releaseinfo-change. It would be the least hassle for the users.

D you think you could prep a PR?

@enoch85
Copy link
Member

enoch85 commented Dec 25, 2022

@morph027 As far as I can tell everything is still working as expected. Do you know when this will go live?

@morph027
Copy link
Collaborator Author

There is no new build since the announcement. So changes to the repo are not live. Other repos are working fine. Do we want to schedule the change? Or wait until the next upstream release?

enoch85 added a commit that referenced this issue Dec 26, 2022
Fix for #2392

Signed-off-by: Daniel Hansson <[email protected]>
@enoch85
Copy link
Member

enoch85 commented Dec 27, 2022

@morph027 Did you have time to check my PR?

@morph027
Copy link
Collaborator Author

Will do tonight, was travelling yesterday...

enoch85 added a commit that referenced this issue Dec 27, 2022
* Upgrade repository for Talk

Fix for #2392

Signed-off-by: Daniel Hansson <[email protected]>

* check for package, not for app

Signed-off-by: Daniel Hansson <[email protected]>

Signed-off-by: Daniel Hansson <[email protected]>
@enoch85
Copy link
Member

enoch85 commented Dec 27, 2022

Please go ahead and push your fix @morph027

@enoch85 enoch85 closed this as completed Dec 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants