Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: duplicated rows in protein_entity.tsv #135

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Bugfix: duplicated rows in protein_entity.tsv #135

merged 2 commits into from
Sep 16, 2024

Conversation

tillenglert
Copy link
Collaborator

@tillenglert tillenglert commented Sep 13, 2024 •
edited
Loading

When multiple microbiomes with different weights exist, the resulting protein_entities.tsv will be duplicated.

This PR fixes the bug and updates all snapshots for the tests

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/metapep branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 13, 2024 •
edited
Loading

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit dde3c9b

+| ✅ 195 tests passed       |+
#| ❔   2 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.0.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • nfcore_yml - nf-core version not set in .nf-core.yml

❔ Tests ignored:

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-09-13 13:18:03

tillenglert added a commit to tillenglert/metapep that referenced this pull request Sep 13, 2024
@tillenglert
Remove TODO (solved by PR nf-core#135)
eddab30
tillenglert added a commit to tillenglert/metapep that referenced this pull request Sep 13, 2024
@tillenglert
Add bugfix from nf-core#135 for testing on cfc
4d52218
@tillenglert tillenglert merged commit 825420d into nf-core:dev Sep 16, 2024
21 checks passed
@tillenglert tillenglert deleted the bugfix/duplicated_rows_protein_entities branch September 30, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skrakau skrakau skrakau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tillenglert @skrakau