Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XML Namespace support. #56

Open
tomc974 opened this issue Jul 2, 2018 · 2 comments
Open

XML Namespace support. #56

tomc974 opened this issue Jul 2, 2018 · 2 comments

Comments

@tomc974
Copy link

tomc974 commented Jul 2, 2018

Could you please consider adding XML Namespace support to your library?

Contrary to what's written in your README, the underlying sax-js parser seems to support namespaces just fine provided you set the xmlns setting to true. Adding fields for local, prefix, and uri should be easy but I'm not sure how the names should be handled with methods such as childNamed()...
@nfarina
Copy link
Owner

nfarina commented Jul 2, 2018

I think it would be fine to support it as long as the existing API is preserved and it doesn’t complicate the codebase too much. Open to suggestions or PRs!

@tinesoft
Copy link

Any update on that issue?
It would be a huge improvement of that already-great library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nfarina @tomc974 @tinesoft