Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update max_message_size to reflect nap behavior change - https://docs.nginx.com/nginx-app-protect-waf/releases/release-notes-4.7/#resolved-issues #5209

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Update max_message_size to reflect nap behavior change - https://docs.nginx.com/nginx-app-protect-waf/releases/release-notes-4.7/#resolved-issues #5209

merged 6 commits into from
Aug 20, 2024

Conversation

jnewfield
Copy link
Contributor

Proposed changes

Update max_message_size in example to be compatible with nap behavior change (after behavior change current example will result in NIC deployment failure) - https://docs.nginx.com/nginx-app-protect-waf/releases/release-notes-4.7/#resolved-issues

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jnewfield
Update max_message_size configuration.md
f4f16a7 
Signed-off-by: Jacob (Jake) Newfield <[email protected]>
@jnewfield jnewfield requested review from a team as code owners March 6, 2024 22:52
@netlify Netlify
Copy link

netlify bot commented Mar 6, 2024 •
edited
Loading

👷 Deploy request for nginx-kubernetes-ingress pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9b3944c

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 6, 2024
@vepatel vepatel self-requested a review March 7, 2024 09:25
ADubhlaoich
ADubhlaoich approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM docs-wise

@pdabelf5 pdabelf5 merged commit 0a6647b into nginxinc:main Aug 20, 2024
29 checks passed
pdabelf5 pushed a commit that referenced this pull request Aug 20, 2024
@jnewfield @pdabelf5
Update max_message_size to reflect nap behavior change - https://docs…
a3cac2f 
….nginx.com/nginx-app-protect-waf/releases/release-notes-4.7/#resolved-issues (#5209)

Update max_message_size configuration.md
@pdabelf5 pdabelf5 mentioned this pull request Aug 20, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@danielnginx danielnginx danielnginx left review comments

@ADubhlaoich ADubhlaoich ADubhlaoich approved these changes

@jjngx jjngx jjngx approved these changes

Assignees

@vepatel vepatel

Labels
documentation Pull requests/issues for documentation
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jnewfield @ADubhlaoich @vepatel @jjngx @danielnginx @pdabelf5 @j1m-ryan